Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for jupyterlab dev spaces #107

Merged

Conversation

MoritzLaurer
Copy link
Collaborator

What does this PR do?

Adding the recipe for jupyterlab spaces and dev mode for interactive development in HF Spaces for enterprise hub cookbook.

Who can review?

@stevhliu @merveenoyan

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Mostly nits :)

notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
notebooks/en/enterprise_cookbook_dev_spaces.md Outdated Show resolved Hide resolved
@MoritzLaurer
Copy link
Collaborator Author

Thank you so much @stevhliu and @merveenoyan for your reviews!
I've implemented all suggestions. From my side, the PR is ready to be merged.

@stevhliu stevhliu merged commit de9a4ff into huggingface:main Jun 7, 2024
1 check passed
@MoritzLaurer MoritzLaurer deleted the enterprise-dev-spaces-recipe branch June 10, 2024 09:57
@MoritzLaurer MoritzLaurer restored the enterprise-dev-spaces-recipe branch June 10, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants