Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated advanced RAG notebook dependencies #121

Merged

Conversation

sergiopaniego
Copy link
Contributor

What does this PR do?

Fixes #120.
I added dependencies installation to solve issues when running using Colab.

Who can review?

@merveenoyan and @stevhliu.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sergiopaniego sergiopaniego changed the title Updated advanced RAG dependencies Updated advanced RAG notebook dependencies Jun 14, 2024
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these dependency issues! langchain-community was already added in #116 so I think we can remove that here

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sergiopaniego
Copy link
Contributor Author

Thanks for fixing these dependency issues! langchain-community was already added in #116 so I think we can remove that here

#116 was a PR for the Simple RAG for GitHub issues using Hugging Face Zephyr and LangChain notebook and this PR is for the Advanced RAG on Hugging Face documentation using LangChain one 😄

@stevhliu
Copy link
Member

Ah my bad! Everything looks then and thanks again! 🙂

@stevhliu stevhliu merged commit 113aa86 into huggingface:main Jun 14, 2024
1 check passed
@sergiopaniego sergiopaniego deleted the updated_notebook_dependencies branch June 14, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some modules not found in advanced RAG notebook when running in Colab
3 participants