-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a RAG via Elasticsearch, Hugging Face models cookbook #124
Add a RAG via Elasticsearch, Hugging Face models cookbook #124
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
5c3c9d5
to
dca29ad
Compare
I thought it would be useful to provide a cookbook for a RAG backed by Elasticsearch, Huggingface models, and Gemma. Users can easily toggle between vectorisation that is offloaded to ES and self-provided (pre)-vectorisation. This is based on the excellent MongoDB notebook and dataset. Signed-off-by: lloydmeta <[email protected]>
dca29ad
to
e0353f7
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👏
Signed-off-by: lloydmeta <[email protected]>
Thanks for your thorough review @stevhliu 🙇♂️ As noted above, the image change requires merging https://huggingface.co/datasets/huggingface/cookbook-images/discussions/20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more minor changes and then I think we're ready to merge! 🙂
Signed-off-by: lloydmeta <[email protected]>
Thanks @stevhliu , really appreciate your patience in this review; it's my first Jupyter notebook PR and I'm not used to the UI (e.g. accidentally adding a blank cell 🤦🏻♂️) and the way diffs/suggestions are shown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot! left a nit :)
Move the embedding and embedding model-related settings down. Add some links and info Signed-off-by: lloydmeta <[email protected]>
* Fix Eland version to avoid breaking changes * Switch to CPU usage by default Signed-off-by: lloydmeta <[email protected]>
Signed-off-by: lloydmeta <[email protected]>
Signed-off-by: lloydmeta <[email protected]>
Signed-off-by: lloydmeta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and thanks again for the notebook! 👏
What does this PR do?
I thought it would be useful to provide a cookbook for a RAG backed by Elasticsearch, Hugging Face models, and Gemma.
Users can easily toggle between vectorisation that is offloaded to ES and self-provided (pre)-vectorisation.
Who can review?
Feel free to tag members/contributors who may be interested in your PR.