Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved small issues when running RAG evaluation notebook in Colab #126

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

sergiopaniego
Copy link
Contributor

What does this PR do?

Fixes #125

Solves the following problems when running the RAG evaluation notebook in Colab:

  • Modules langchain-community and ragatouille are not installed.
  • The link to a recommended read (Greg Kamradt's notebook) is broken.
  • The API tokens for HF and OpenAI are not stated.
  • BaseChatModel is not imported

Who can review?

@merveenoyan and @stevhliu.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all these issues with the RAG notebooks! 🤗

@stevhliu stevhliu merged commit 536d4b6 into huggingface:main Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some issues are raised when running rag evaluation notebook in Colab
3 participants