Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple RAG use-case to support latest LangChain syntax #32

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

jacoblee93
Copy link
Contributor

@jacoblee93 jacoblee93 commented Feb 17, 2024

What does this PR do?

Switches the legacy LangChain LLMChain to use expression language, which modernizes/removes some of the parsing.

Who can review?

Feel free to tag members/contributors who may be interested in your PR.

@MKhalusova

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jacoblee93 jacoblee93 changed the title Update simple RAG use-case to support streaming Update simple RAG use-case to support latest LangChain syntax Feb 17, 2024
@MKhalusova MKhalusova self-requested a review February 19, 2024 13:22
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@@ -1,23 +1,10 @@
{
Copy link
Contributor

@MKhalusova MKhalusova Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add a code cell here?


Reply via ReviewNB

@MKhalusova
Copy link
Contributor

Thanks for improving the example! It looks like there's a code cell missing at the end though. Can you check?

@jacoblee93
Copy link
Contributor Author

Oh, shoot - yeah I dropped an extra section and forgot to remove the lead-in. Will fix.

@jacoblee93
Copy link
Contributor Author

Will manually cherry pick the change in the interim.

@MKhalusova
Copy link
Contributor

For the conflict, feel free to override with your changes. Notebook conflicts are a pain to resolve, and the conflicting change is super minor - I can redo it in a separate PR.

@jacoblee93
Copy link
Contributor Author

Yeah the diff was odd - I readded _Authored by: [Maria Khalusova](https://github.com/MKhalusova)_ which I think was the only thing?

@jacoblee93
Copy link
Contributor Author

LMK if that looks better

@MKhalusova
Copy link
Contributor

Yeah the diff was odd - I readded _Authored by: [Maria Khalusova](https://github.com/MKhalusova)_ which I think was the only thing?

Yes, that was the only thing added. Thanks for re-adding it!

Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@MKhalusova MKhalusova merged commit 598aa52 into huggingface:main Feb 19, 2024
1 check passed
@jacoblee93
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants