use RecursiveCharacterTextSplitter to better split docs #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of specified size
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
MKhalusova
reviewed
Feb 21, 2024
MKhalusova
reviewed
Feb 21, 2024
MKhalusova
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Simple RAG notebook currently uses the CharacterTextSplitter langchain method for splitting. This returns a stream of warnings of creating chunks that are longer than the specified size as the default separator is
\n\nThey provide another method RecursiveCharacterTextSplitter that by default splits over
["\n\n", "\n", " ", ""], giving us chunks closer to the size we set.Who can review?
Feel free to tag members/contributors who may be interested in your PR.
@MKhalusova