-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constrained generation cookbook #64
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
4349c20
to
93eeddc
Compare
9cd76a0
to
09a5f2a
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
3c22a1a
to
3e2a3b2
Compare
Sweet recipe! I think the structure can be improved a bit so its clearer what users are doing exactly in a specific section. You started with saying "This notebook demonstrates structured generation on two inference methods", so I think my expectation was for the notebook to be structured that way. The two topics, prompting and grammar, can be discussed within the larger context of these two sections. # RAG with source highlighting using constrained generation
## Hugging Face Inference Endpoints
## Outlines |
Thank you! Since I think the distinction of prompting VS constrained generation is more interesting than HF vs Outlines, I prefer to emphasize in the intro the prompting VS constrained generation dichotomy, then only mention the use of Outlines as an extra. |
@stevhliu I changed the name of the notebook to "structured_generation" to represent a wider topic ("constrained generation" is only a method to achieve "structured generation"). Then its subparts are prompting (naive approach) and constrained generation (advanced approach). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more suggestions, but otherwise, I think this looks very good and can be merged once the comments are addressed!
What does this PR do?
Add a cookbook on constrained generation.
Who can review?
@MKhalusova