Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Catala as new language in notebooks/translated rag_zephyr_langchain #77

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JanLeyva
Copy link

@JanLeyva JanLeyva commented Apr 5, 2024

What does this PR do?

This PR adds the folder ca to the notebooks directory. The purpose is to include translated notebooks in Catalan, as well as to translate the rag_zephyr_langchain notebook into this language. I have already translated Index.md inside the ca folder and made modifications to _toctree.yaml as well.

This marks my first contribution, and I welcome any feedback!

Who can review?

Someone that can check I did the structure properly, no technical changes made just translated a notebook and added a language.
@adeenayakup @MKhalusova

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JanLeyva
Copy link
Author

@MKhalusova @davanstrien can you please take a look? or give me feedback, thanks!

@blademoon
Copy link

@JanLeyva Hello. In order to fully add language support, a couple more edits need to be made.

image

You can see how I did it for Russian.

image

@JanLeyva
Copy link
Author

@blademoon added ca as a language in build_documentation.yml and build_pr_documentation.yml in .github/workflows. Thanks for pointing this out, completely missed this step.

@blademoon
Copy link

@stevhliu Good day. Can you approve doc preview building?

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translating to Catalan!

I can't speak/read the language though, so would it be possible for you to find someone who may be interested in reviewing your translation for accuracy? The forums or Discord could be good places to find a potential collaborator 🙂

sections:
- local: index
title: Open-Source AI Cookbook
- local: rag_zephyr_langchain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't aligned which caused the doc building to fail. I think it'd also be nice to translate the title of the recipe here to Catalan

Suggested change
- local: rag_zephyr_langchain
- local: rag_zephyr_langchain

@@ -0,0 +1,21 @@
# Open-Source AI Cookbook

The Open-Source AI Cookbook is a collection of notebooks illustrating practical aspects of building AI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some of this isn't translated to Catalan yet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking!

I just fixed the problem with _toctree.yml sorry about that, as well as full translated index.md to catalan. I'll look for more collaborators there, really appreciated!

fixing PR caused by error in `_toctree.yml`
translated to català
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants