Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rustls's aws-lc-rs feature #71

Closed
wants to merge 1 commit into from
Closed

Disable rustls's aws-lc-rs feature #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ rand = { version = "0.8.5", optional = true }
reqwest = { version = "0.12.2", optional = true, default-features = false, features = [
"json",
] }
rustls = { version = "0.23.4", optional = true }
rustls = { version = "0.23.4", optional = true, default-features = false, features = [
"ring",
] }
serde = { version = "1", features = ["derive"], optional = true }
serde_json = { version = "1", optional = true }
thiserror = { version = "2", optional = true }
Expand All @@ -43,7 +45,7 @@ default = ["default-tls", "tokio", "ureq"]
# These features are only relevant when used with the `tokio` feature, but this might change in the future.
default-tls = []
native-tls = ["dep:reqwest", "reqwest/default", "dep:native-tls", "ureq/native-tls"]
rustls-tls = ["dep:rustls", "reqwest/rustls-tls"]
rustls-tls = ["dep:reqwest", "dep:rustls", "reqwest/rustls-tls"]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added back the dep:reqwest to the rustls-tls feature, as it didn't make sense to me not to depend on this crate in the rustls-tls case. LMK if I missed something.

tokio = [
"dep:futures",
"dep:indicatif",
Expand Down