Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deps by letting reqwest deal with rustls (ring vs aws-lc-rs). #88

Merged
merged 17 commits into from
Jan 7, 2025
Merged

Simplify deps by letting reqwest deal with rustls (ring vs aws-lc-rs). #88

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6d09ea6
Simplify deps by letting reqwest deal with rustls (ring vs aws-lc-rs).
Narsil Jan 7, 2025
ac61e39
Trying to see the error in DL.
Narsil Jan 7, 2025
747e57f
Trying to nail the issue.
Narsil Jan 7, 2025
ee5728e
More test.
Narsil Jan 7, 2025
66cd257
Trying to trigger more frequently.
Narsil Jan 7, 2025
cf246bf
Oops.
Narsil Jan 7, 2025
abf2254
??
Narsil Jan 7, 2025
8d25cbe
??
Narsil Jan 7, 2025
3ea273e
??
Narsil Jan 7, 2025
7d30d9c
Cargo feature syntax.
Narsil Jan 7, 2025
ed37a90
Tmp
Narsil Jan 7, 2025
be46fb3
Tokio needs sync ?
Narsil Jan 7, 2025
5cd51ce
It's hard to track..
Narsil Jan 7, 2025
d790e44
Can we trust tokio::fs ?
Narsil Jan 7, 2025
dcbe07d
Remove the extra check.
Narsil Jan 7, 2025
486a7f1
Requires flush?
Narsil Jan 7, 2025
ab91931
Cancel the other unrelated changes.
Narsil Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ reqwest = { version = "0.12.2", optional = true, default-features = false, featu
"json",
"stream",
] }
rustls = { version = "0.23.4", optional = true }
serde = { version = "1", features = ["derive"], optional = true }
serde_json = { version = "1", optional = true }
thiserror = { version = "2", optional = true }
Expand All @@ -43,8 +42,8 @@ native-tls = { version = "0.2.12", optional = true }
default = ["default-tls", "tokio", "ureq"]
# These features are only relevant when used with the `tokio` feature, but this might change in the future.
default-tls = ["native-tls"]
native-tls = ["dep:reqwest", "reqwest/default", "dep:native-tls", "ureq/native-tls"]
rustls-tls = ["dep:rustls", "reqwest/rustls-tls"]
native-tls = ["dep:reqwest", "reqwest?/default", "dep:native-tls", "dep:ureq", "ureq?/native-tls"]
rustls-tls = ["reqwest?/rustls-tls"]
tokio = [
"dep:futures",
"dep:indicatif",
Expand Down
Loading