Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export type ModelDataMinimal #1035

Closed
wants to merge 1 commit into from
Closed

export type ModelDataMinimal #1035

wants to merge 1 commit into from

Conversation

mishig25
Copy link
Collaborator

export type ModelDataMinimal because it is needed in moon

julien-c
julien-c reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bit weird bc ModelData is originally in moon-landing, so it's weird/cyclical to re-import a partial copy of it

I'd rather redefine it in moon-landing in some way

@mishig25
Copy link
Collaborator Author

yeah indeed, that would be better

@mishig25 mishig25 closed this Nov 15, 2024
@mishig25 mishig25 deleted the export_ModelDataMinimal branch November 15, 2024 16:14
@coyotte508
Copy link
Member

coyotte508 commented Nov 15, 2024 •
edited
Loading

JFI it's already exported as part of #1026

via snippets.ModelDataMinimal

(at least it should be)

@coyotte508 coyotte508 mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c left review comments

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

@ngxson ngxson Awaiting requested review from ngxson ngxson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mishig25 @coyotte508 @julien-c