Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies upper bounds constraints #145

Merged
merged 10 commits into from
May 8, 2024

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented May 7, 2024

What this does

Remove upper bounds contraints on most dependencies (except torch and mujoco).

Related:

How it was tested

Using the regular testing suite
Additionally, did a build/test cycle to make sure everything runs ok: https://github.com/huggingface/lerobot/actions/runs/9001567510

@aliberts aliberts added the ➡️ Dependencies Adding, removing or updating dependencies label May 7, 2024
@aliberts aliberts self-assigned this May 7, 2024
@aliberts aliberts changed the title Try updated environments Remove dependencies upper bounds constraints May 7, 2024
pyproject.toml Outdated Show resolved Hide resolved
@aliberts aliberts marked this pull request as ready for review May 8, 2024 12:27
@aliberts aliberts requested a review from Cadene May 8, 2024 12:27
Copy link
Collaborator

@alexander-soare alexander-soare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon. One comment.

pyproject.toml Outdated
h5py = "^3.10.0"
huggingface-hub = "^0.21.4"
opencv-python = ">=4.9.0"
diffusers = ">=0.27.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only diffusion policy relies on diffusers and I'd like to remove this reliance so that we don't get bitten by b/c changes. Can we keep this version constraint tight?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: cc087ea

@aliberts aliberts force-pushed the user/aliberts/2024_05_07_remove_upper_bounds branch from dc330f8 to cc087ea Compare May 8, 2024 17:19
@aliberts aliberts enabled auto-merge (squash) May 8, 2024 17:20
Copy link
Collaborator

@alexander-soare alexander-soare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@aliberts aliberts merged commit 7bb5b15 into main May 8, 2024
4 checks passed
@aliberts aliberts deleted the user/aliberts/2024_05_07_remove_upper_bounds branch May 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➡️ Dependencies Adding, removing or updating dependencies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants