Update cached models and benchmarks #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minimum version is required by toch_neuronx (but not enforced).
dacorvo
force-pushed
the
update_benchmarks
branch
from
37e7222 to
7a8e99c
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
JingyaHuang
approved these changes
Sep 26, 2024
| @@ -27,7 +25,7 @@ def main(): | |||
| export=True, | |||
| batch_size=batch_size, | |||
| sequence_length=seq_length, | |||
| auto_cast_type="fp16", | |||
| auto_cast_type="bf16", | |||
There was a problem hiding this comment.
So it's now proven that bf16 is better?
There was a problem hiding this comment.
It actually does not make any difference as far as I can tell, and this seems to allow to load weights faster (because they are not converted).
|
I have made a small modification in the export code to always set |
dacorvo
force-pushed
the
update_benchmarks
branch
from
d514284 to
337d882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This modifies the cache population workflow to use the files corresponding to new models.
This also updates the benchmark in the documentation.