Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added num_cores argument to neuron #737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gaarutyunov
Copy link

What does this PR do?

Added num_cores argument to optimum-cli export neuron

Fixes # (issue)

Was getting AttributeError: 'Namespace' object has no attribute 'num_cores' on optimum-cli export neuron

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter is not supported for neuron, only for neuronx.

@gaarutyunov
Copy link
Author

This parameter is not supported for neuron, only for neuronx.

It is used here and results in an AttributeError I've mentioned in the issue.

Should I stick to export neuronx? Is export neuron still supported?

@gaarutyunov
Copy link
Author

It is also mentioned in the docs here in the section Exporting LLMs to Neuron.

@dacorvo
Copy link
Collaborator

dacorvo commented Nov 18, 2024

@gaarutyunov I agree this is confuzing but really this all applies to neuronx export, even if the name is neuron.

@JingyaHuang
Copy link
Collaborator

Hi @gaarutyunov, are you using inf1 instances? The export of LLMs is not supported by inferentia 1, you might want to use inferentia 2 instances as an alternative.

@gaarutyunov
Copy link
Author

Hi @gaarutyunov, are you using inf1 instances? The export of LLMs is not supported by inferentia 1, you might want to use inferentia 2 instances as an alternative.

Ok, thank you for clarifying this, it wasn't clear from the documentation. I will try inf2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants