feat: move allocation logic to rust #1835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierDehaene
force-pushed
the
feat/move_cache_manager_rust
branch
from
9ff4f18 to
a9beab0
Compare
Narsil
reviewed
May 31, 2024
| window_size: Option<u32>, | ||
| ) -> Self { | ||
| // Create channel | ||
| let (sender, receiver) = mpsc::unbounded_channel(); |
Contributor
There was a problem hiding this comment.
Unrelated to the PR, but maybe it's a culprit for the leaks.
https://docs.rs/tokio/latest/tokio/sync/mpsc/fn.unbounded_channel.html
OlivierDehaene
force-pushed
the
feat/move_cache_manager_rust
branch
from
a9beab0 to
e346b6d
Compare
OlivierDehaene
force-pushed
the
feat/move_cache_manager_rust
branch
from
e346b6d to
9410a79
Compare
zirconium-n
reviewed
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2007