Fix AutoProcessor import order issue with custom classes #35798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing via AutoImageProcessor before AutoProcessor is imported, an AttributeError could occur if the model used custom processor classes. This fix allows custom classes to be loaded from the config object.
|
This is another test of using OpenHands to resolve issues, this time on a more complex one where the solution wasn't clearly laid out in the issue. The PR and comment above were written by the bot. I haven't reviewed it yet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34307
When initializing via AutoImageProcessor before AutoProcessor is imported, an AttributeError could occur if the model used custom processor classes. This happened because the code tried to import the processor class from the root transformers module, which failed for custom classes.
This PR modifies the
_get_arguments_from_pretrainedmethod to look for custom classes in the config object if they are not found in the root module. This allows models to define their own processor classes without having to modify the transformers module itself.Added a test case to verify the fix works as expected.