Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPO: Scalable training with one LLM/node #3186

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jglaser
Copy link

@jglaser jglaser commented Mar 31, 2025

What does this PR do?

Allow scalable training with GRPO + 1 local vllm process per node. Also works with FSDP.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [X ] Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Caveat:

  • currently disables the multi-generation optimization as that one does not seem to be robust w.r.t. duplicate user inputs

jglaser added 8 commits March 7, 2025 15:04
- Temporarily disable optimations for multiple generations from the
same prompt
- Compute number of local proceses using collective
- Strip FSDP checkpointing artifact from parameter names
relevant for multiple processes posting requests to the same
server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant