🟩 Drop image_split_sizes in favour of image_grid_thw
#4111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_thw` in GRPO and RLOO trainers; update `split_pixel_values_by_grid` to use `image_grid_thw`
qgallouedec
commented
Sep 19, 2025
|
|
||
| if hasattr(self.processing_class, "_get_num_multimodal_tokens"): | ||
| image_sizes = [(image.height, image.width) for image in images] | ||
| multimodal_extra_data = self.processing_class._get_num_multimodal_tokens(image_sizes) |
There was a problem hiding this comment.
it also avoids calling a private method
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Sep 19, 2025
lewtun
approved these changes
Sep 22, 2025
| **kwargs, | ||
| ) | ||
| prompt_inputs = super(_GRPOTrainer, self)._prepare_inputs(prompt_inputs) | ||
| prompt_inputs = super()._prepare_inputs(prompt_inputs) |
| if "image_grid_thw" not in batch or "pixel_values" not in batch: | ||
| return batch | ||
|
|
||
| lengths = batch["image_split_sizes"] # [batch_size] |
There was a problem hiding this comment.
Do I understand correctly, that image_split_sizes was only really used in this helper method to extract the image lengths? If so, then I agree it's redundant with image_grid_thw
qgallouedec
changed the title
image_split_sizes in favour of image_grid_thwimage_split_sizes in favour of image_grid_thw
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR belongs to a sequence of PR that aims to refactor the generation part of GRPO/RLOO to allow for easier customization and ultimately tool calling
Next:
_generate#4114_generatein GRPO/RLOO: list of ints instead of tensors #4146_generatein GRPO/RLOO: Useprompt_idsfrom generation #4152_generatein GRPO/RLOO: Rely on generator for prompt truncation #4153_generatein GRPO/RLOO: Moveforward_kwargsoutside generation method #4154_generatein GRPO/RLOO: Insert images in the prompt #4155While refactoring, I realized that having
image_split_sizesactually doesn't help much, and is redundant withimage_grid_thw. Consequently, I suggest to revert #4032