Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor treadmill controls #94

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor treadmill controls #94

wants to merge 4 commits into from

Conversation

HoLuLuLu
Copy link
Contributor

  • Use two buttons
    • left button for start/pause/resume
      • start button will switch to pause button if workout started by clicking on it
      • pause button will switch to resume button if workout paused by clicking on it
      • resume button will switch to pause button if workout resumed by clicking on it
    • right button for stop
      • button is deactivated until workout started
      • clicking on it will stop the workout and reset the button layouts
  • Use current workout state from WorkoutStateManager
  • Add timer to display countdown in app (will interrupt if pad starts earlier)
  • Add comments on some checks

FitnessMachine_pause
FitnessMachine_resume
FitnessMachine_start

@HoLuLuLu
Refactor treadmill controls
2ee5965 
- Use two buttons
- Use current workout state from workout_state_manager.dart for buttons
@HoLuLuLu
Add visual timer
567de76 
- Add timer to display countdown in app (will interrupt if pad starts earlier)
- Add some comments on some checks
- Fix _listen()
@HoLuLuLu
Copy link
Contributor Author

This should affect #54

@hughesjs
Copy link
Owner

Hi mate, I have been so busy this last few weeks, I've only just seen your PRs come in, sorry! I'll try and get them all reviewed this weekend. Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HoLuLuLu @hughesjs