Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Speed Indicator #99

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

HoLuLuLu
Copy link
Contributor

  • Enlarge the size of current speed
  • Relocate min/max speed under indicator line
  • Add unit and unit name at the bottom of the card
  • Use +/- Icons for buttons

Screenshots:
SpeedIndicator_dark
SpeedIndicator_light

@HoLuLuLu
Copy link
Contributor Author

It seems that I am using a newer version of flutter on my local PC (3.24.3) and the github action uses 3.19.5 which causes the build to fail because:

'MaterialStatePropertyAll' is deprecated and shouldn't be used. Use WidgetStatePropertyAll instead. Moved to the Widgets layer to make code available outside of Material. This feature was deprecated after v3.19.0-0.3.pre.

I use the recommended replacement WidgetStatePropertyAll which seems to not be included in the older flutter version used by the GH action. Maybe it's the better fix to update the flutter version in the github action instead of using a deprecated class which will be removed in more modern versions.

@hughesjs
Copy link
Owner

hughesjs commented Oct 4, 2024

I've merged your fvm PR. Sorry I'm being a bit slow atm, I've just started a new job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants