Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update as-pect and assemblyscript version #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jtenner
Copy link

@jtenner jtenner commented Jul 18, 2019

A new version of the as-pect cli was released.

Thanks for using as-pect!

@hugomrdias
Copy link
Owner

Thank you for the PR but i need to update the code to the last assemblyscript version, im still using the old syntax.

@jtenner
Copy link
Author

jtenner commented Aug 1, 2019

Let me take a look and see if I can help you with that.

@jtenner
Copy link
Author

jtenner commented Aug 1, 2019

It looks like I can update a lot of your packages and get things installed on my machine, but I have some problems with testing.

I am on a windows machine and cannot run the build binary.

It also looks like the example.imports.js file returns a new Uint8Array which cannot be used. That file returns the reference to be passed into web assembly and will be coerced to an i32 as a result. I moved it into the test itself with a create<T>() function that generates the values for you.

@jtenner
Copy link
Author

jtenner commented Aug 1, 2019

All set! Please let me know if you have any questions or need help with the latest version of AssemblyScript 🎉

@hugomrdias
Copy link
Owner

hugomrdias commented Aug 1, 2019

actually can you help me with this ipfs/js-ipfs#2118 (comment) to remove this https://github.com/hugomrdias/rabin-wasm/pull/5/files#diff-1cecc8788b4594868b522b0b733a03d4R49-R52

thank you for your help !!!

@jtenner
Copy link
Author

jtenner commented Aug 1, 2019

Please forgive me if I don't understand what you're asking for, but I do think that this should cover your needs.

Can you please test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants