Skip to content

Fix name_break for current location and add tests#1195

Closed
Kileak wants to merge 1 commit into
hugsy:mainfrom
Kileak:named_bp_fix
Closed

Fix name_break for current location and add tests#1195
Kileak wants to merge 1 commit into
hugsy:mainfrom
Kileak:named_bp_fix

Conversation

@Kileak

@Kileak Kileak commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

Description

Fix for using name-break without specifying an address (which should just set the breakpoint at current pc).
Also adding more thorough tests to check the different usages work.

With the current implementation, when setting a named breakpoint without specifying a location, the location will be set to *$pc. When reattaching to a process, the location of breakpoints gets re-evaluated, which results in all named breakpoints being changed to the current pc when attaching.

The fix will evaluate the location on set now, when no address argument is given and set the breakpoint with a specific address.

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

🤖 Coverage update for cef089c 🔴

Old New
Commit ee605f9 cef089c
Score 71.0775% 71.0582% (-0.0193)

@Grazfather Grazfather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Thank you!

@stale

stale Bot commented Nov 10, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You can reopen it by adding a comment to this issue.

@stale stale Bot added the stale label Nov 10, 2025
@stale

stale Bot commented Dec 11, 2025

Copy link
Copy Markdown

This issue has been automatically closed because it has not had recent activity. If you are the owner of this issue, you can either re-open it and provide a more complete description; or create a new issue. Thank you for your contributions.

@stale stale Bot closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants