Fix handling of RTL files in the manifest #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the WebpackRTLPlugin the manifest doesn't produce entries for both the original and the RTL file. This results in the wrong file being loaded. This is caused by the fact that both files are in the same chunk. There is an issue tracking this on the WebpackRTLPlugin: romainberger/webpack-rtl-plugin#14 This commit includes a workaround. By providing a `map` function to the manifest plugin we can change the name when we're dealing with an RTL file. That results in two entries in the eventual manifest.
kadamwhite
approved these changes
Apr 6, 2021
|
And, published in v0.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the WebpackRTLPlugin the manifest doesn't produce entries for both the original and the RTL file. This results in the wrong file being loaded. This is caused by the fact that both files are in the same chunk.
There is an issue tracking this on the WebpackRTLPlugin: romainberger/webpack-rtl-plugin#14
This commit includes a workaround. By providing a
mapfunction to the manifest plugin we can change the name when we're dealing with an RTL file. That results in two entries in the eventual manifest.cc @kadamwhite, @alwaysblank