Skip to content

Align chambers UI with active-governor denominators… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cyber-preacher merged 1 commit into from
Feb 11, 2026
Merged

Align chambers UI with active-governor denominators… #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/dtoParsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ export function computeChamberMetrics(chambers: ChamberDto[]) {
return sum + acm;
}, 0);
// Governors can be members of multiple chambers; use the largest chamber roster
// as a stable approximation of global active governors for the summary tile.
const activeGovernors = chambers.reduce((max, chamber) => {
// as a stable approximation of global governors for the summary tile.
const governors = chambers.reduce((max, chamber) => {
const { governors } = getChamberNumericStats(chamber);
return Math.max(max, governors);
}, 0);
Expand All @@ -50,7 +50,7 @@ export function computeChamberMetrics(chambers: ChamberDto[]) {
);
return {
totalChambers: chambers.length,
activeGovernors,
governors,
totalAcm,
liveProposals,
};
Expand Down
16 changes: 12 additions & 4 deletions src/pages/chambers/Chambers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ import { Button } from "@/components/primitives/button";
import { Link } from "react-router";
import { InlineHelp } from "@/components/InlineHelp";
import { NoDataYetBar } from "@/components/NoDataYetBar";
import { apiChambers } from "@/lib/apiClient";
import { apiChambers, apiClock } from "@/lib/apiClient";
import {
computeChamberMetrics,
getChamberNumericStats,
} from "@/lib/dtoParsers";
import type { ChamberDto } from "@/types/api";
import type { GetClockResponse } from "@/types/api";
import { Surface } from "@/components/Surface";

type Metric = {
Expand All @@ -34,6 +35,7 @@ const metricCards: Metric[] = [

const Chambers: React.FC = () => {
const [chambers, setChambers] = useState<ChamberDto[] | null>(null);
const [clock, setClock] = useState<GetClockResponse | null>(null);
const [loadError, setLoadError] = useState<string | null>(null);
const [search, setSearch] = useState("");
const [filters, setFilters] = useState<{
Expand All @@ -47,12 +49,15 @@ const Chambers: React.FC = () => {
(async () => {
try {
const res = await apiChambers();
const clockRes = await apiClock().catch(() => null);
if (!active) return;
setChambers(res.items);
setClock(clockRes);
setLoadError(null);
} catch (error) {
if (!active) return;
setChambers([]);
setClock(null);
setLoadError((error as Error).message);
}
})();
Expand Down Expand Up @@ -90,9 +95,12 @@ const Chambers: React.FC = () => {

const computedMetrics = useMemo((): Metric[] => {
if (!chambers) return metricCards;
const { activeGovernors, totalAcm, liveProposals } =
const { governors, totalAcm, liveProposals } =
computeChamberMetrics(chambers);
const governors = activeGovernors;
const activeGovernors = Math.min(
governors,
Math.max(0, Math.floor(clock?.activeGovernors ?? governors)),
);
return [
{ label: "Total chambers", value: String(chambers.length) },
{
Expand All @@ -102,7 +110,7 @@ const Chambers: React.FC = () => {
{ label: "Total ACM", value: totalAcm.toLocaleString() },
{ label: "Live proposals", value: String(liveProposals) },
];
}, [chambers]);
}, [chambers, clock]);

return (
<div className="flex flex-col gap-6">
Expand Down