Skip to content

Commit

Permalink
Changed CreateMessage step order
Browse files Browse the repository at this point in the history
  • Loading branch information
luke- committed Mar 15, 2020
1 parent 461ec32 commit e9da798
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
8 changes: 8 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
Changelog
=========


1.0.14 - Unreleased
-----------------------
- Chg: Internal change in message creation order
- Enh: Updated translations



1.0.13 - February 12, 2020
-----------------------
- Fix: Max. conversation check not disabled
Expand Down
4 changes: 2 additions & 2 deletions models/forms/CreateMessage.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ public function save()
return false;
}

if (!$this->saveMessageEntry()) {
if (!$this->saveRecipients()) {
$transaction->rollBack();
return false;
}

if (!$this->saveRecipients()) {
if (!$this->saveMessageEntry()) {
$transaction->rollBack();
return false;
}
Expand Down

1 comment on commit e9da798

@verement
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the motivation for this change? It seems to have introduced a problem relating to notifications (issue #173).

Please sign in to comment.