Bootstrap Pods needs Humio ServiceAccount #1038
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the HumioServiceAccount to the HumioBootstrapTokenConfig to provide the bootstrap pod with the same permissions the Humio nodepool pods have. This is necessary as the `default` ServiceAccount does not necessarily have permissions to access bucket storage, which can be a requirement for bootstrapping to complete successfully. Add unit tests to validate ServiceAccount is correctly added. Tests: In my environment, we had a workaround for this by adding the S3 bucket access to a node role. Removing that access broke the bootstrapper. Using this PR fixed the bootstrapper. Risk: Low - only mounts the ServiceAccount to one new location. There might be a race condition in when the ServiceAccount is created vs. when the bootstrapper Pod is created, but if there is, it resolves on its own without intervention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the HumioServiceAccount to the HumioBootstrapTokenConfig to provide the bootstrap pod with the same permissions the Humio cluster pods have. This is necessary as the
defaultServiceAccount does not necessarily have permissions to access bucket storage, which can be a requirement for bootstrapping to complete successfully.Add unit tests to validate ServiceAccount is correctly added.
Resolves #1037 .
Tests: In my environment, we had a workaround for this by adding the S3 bucket access to a EC2 node role. Removing that access broke the bootstrapper. Using this PR fixed the bootstrapper.
Risk: Low - only mounts the ServiceAccount to one new location. There might be a race condition in when the ServiceAccount is created vs. when the bootstrapper Pod is created, but if there is, it resolves on its own without intervention.