Merge pull request crossplane-contrib#9 from humoflife/unit-tests

updated unit tests, removed v1beta1, simplfied code, updated README

README.md

@@ -15,12 +15,12 @@ is expected to follow the above pattern.
 The `function-shell` accepts commands to run in a shell and it
 returns the output to specified fields. It accepts the following parameters:
 
-- `shellScriptsConfigMapsRef` - referencing at least one Kuberneres
+- `shellScriptsConfigMapsRef` - referencing at least one Kubernetes
 [`ConfigMap`](https://kubernetes.io/docs/concepts/configuration/configmap/)
 with at least one shell script. This script can be written in an arbitrary
 shell language, for example bash or python3.
 - `shellEnvVarsSecretRef` - referencing environment variables in a
-  Kubernetes secret. `shellEnvVarsSecretRef` requires a `name`, a
+Kubernetes secret. `shellEnvVarsSecretRef` requires a `name`, a
 `namespace` and a `key` for the secret. Inside of it, the shell
 expects a JSON structure with key value environment variables. Example:
 

fn_test.go

@@ -187,32 +187,6 @@ func TestRunFunction(t *testing.T) {
 				},
 			},
 		},
-		"ResponseIsSecretError": {
-			reason: "The Function should return an error when secrets are not loadable",
-			args: args{
-				req: &fnv1beta1.RunFunctionRequest{
-					Meta: &fnv1beta1.RequestMeta{Tag: "hello"},
-					Input: resource.MustStructJSON(`{
-						"apiVersion": "template.fn.crossplane.io/v1alpha1",
-						"kind": "Parameters",
-						"shellEnvVarsSecretRef": {"name": "test-secret", "namespace": "crossplane-system", "key": "credentials"},
-						"shellCommand": "echo testing",
-						"stdoutField": "spec.atFunction.shell.stdout"
-					}`),
-				},
-			},
-			want: want{
-				rsp: &fnv1beta1.RunFunctionResponse{
-					Meta: &fnv1beta1.ResponseMeta{Tag: "hello", Ttl: durationpb.New(response.DefaultTTL)},
-					Results: []*fnv1beta1.Result{
-						{
-							Severity: fnv1beta1.Severity_SEVERITY_FATAL,
-							Message:  "cannot process contents of secret test-secret in namespace crossplane-system: Secret test-secret in namespace crossplane-system not found\n",
-						},
-					},
-				},
-			},
-		},
 	}
 
 	for name, tc := range cases {
@@ -229,4 +203,4 @@ func TestRunFunction(t *testing.T) {
 			}
 		})
 	}
-}
+}

script.go

@@ -78,9 +78,7 @@ func getScripts(clientset *kubernetes.Clientset, shellScriptsConfigMapRef v1alph
 	}
 
 	for _, scriptName := range scriptNames {
-		for _, scriptLine := range strings.Split(scriptConfigMap.Data[scriptName], "\n") {
-			scripts[scriptName] = append(scripts[scriptName], scriptLine)
-		}
+		scripts[scriptName] = append(scripts[scriptName], strings.Split(scriptConfigMap.Data[scriptName], "\n")...)
 	}
 
 	return scripts, nil