Minor fixes and code adjustments

hungersoft · Dec 3, 2019 · c1a9fed · c1a9fed
1 parent 4a83757
commit c1a9fed
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/Observer/Register.php b/Observer/Register.php
@@ -8,31 +8,31 @@
 
 namespace HS\LoginAsCustomer\Observer;
 
+use HS\All\Helper\Data;
+use Magento\Framework\Event\Observer;
 use Magento\Framework\Event\ObserverInterface;
 
 class Register implements ObserverInterface
 {
     /**
-     * @var \HS\All\Helper\Data
+     * @var Data
      */
-    protected $helper;
+    private $helper;
 
     /**
-     * @param \HS\All\Helper\Data $helper
-     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
+     * @param Data $helper
      */
-    public function __construct(
-        \HS\All\Helper\Data $helper
-    ) {
+    public function __construct(Data $helper)
+    {
         $this->helper = $helper;
     }
 
     /**
      * Register extension.
      *
-     * @param \Magento\Framework\Event\Observer $observer
+     * @param  Observer $observer
      */
-    public function execute(\Magento\Framework\Event\Observer $observer)
+    public function execute(Observer $observer)
     {
         $this->helper->register('HS_LoginAsCustomer', '1.0.0', 'confirm');
     }

diff --git a/etc/acl.xml b/etc/acl.xml
@@ -6,7 +6,7 @@
                 <resource id="Magento_Customer::customer">
                     <resource id="HS_LoginAsCustomer::AdminLogin" sortOrder="10" title="Admin Login">
                         <resource id="HS_LoginAsCustomer::login_as_customer_button" sortOrder="30" title="Login as customer button"/>
-                        <resource id="HS_LoginAsCustomer::login_as_customer_log" sortOrder="40" title="View Admin Login"/>
+                        <resource id="HS_LoginAsCustomer::login_as_customer_view" sortOrder="40" title="View Admin Login"/>
                     </resource>
                 </resource>
                 <resource id="Magento_Backend::stores">