Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve nested button DOM warning #4

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix: resolve nested button DOM warning #4

merged 2 commits into from
Aug 14, 2024

Conversation

condorheroblog
Copy link
Contributor

Closed #3

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-tiptap-4q2x ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 10:11am

@hunghg255 hunghg255 merged commit c3b0d74 into hunghg255:master Aug 14, 2024
2 checks passed
@condorheroblog
Copy link
Contributor Author

Excuse me, I have a question for you.

Do you have any plans to upgrade ESLint to the latest version(V8)? Or just use this package @antfu/eslint-config.

Have a good nice day.

@hunghg255
Copy link
Owner

@antfu/eslint-config

Yes, I also want to use flat config. I see many eslint plugins still not upgraded

@condorheroblog
Copy link
Contributor Author

That's great, and I think we do not need Prettier anymore, but it's all up to you.😉

@hunghg255
Copy link
Owner

hunghg255 commented Aug 14, 2024

That's great, and I think we do not need Prettier anymore, but it's all up to you.😉

oke, I will upgrade soon,
I want to share this. I cloned the emoji extension by download js file from the network on tiptap docs. https://tiptap-emoji.surge.sh/
but because of the license I did a warning so I can not push code to this repo =)))

@hunghg255
Copy link
Owner

If you are interested, I will invite you to the repo

@condorheroblog
Copy link
Contributor Author

Nice, please🥰

@hunghg255
Copy link
Owner

Nice, please🥰

ok I invited you to repo

@condorheroblog
Copy link
Contributor Author

Thank you very much 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested <button> elements causing DOM validation warning
2 participants