-
-
Notifications
You must be signed in to change notification settings - Fork 347
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: line wrapping in Select component (#691)
- Loading branch information
1 parent
0642be4
commit 811a062
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
811a062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
shadcn-svelte – ./
shadcn-svelte-git-main-huntabyte.vercel.app
shadcn-svelte-huntabyte.vercel.app
shadcn-svelte.vercel.app
www.shadcn-svelte.com
shadcn-svelte.com
811a062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Scooter1337 This change broke all my select components. Trigger is now displayed in the bottom-left corner instead of center-right side. I do not have any custom styles for selects.
811a062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a repro? I can’t reproduce this issue in Safari (Mobile and Desktop) nor in Chrome, and Edge.
The styles I added are copied directly from the original shadcn/ui library.
811a062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Scooter1337 I don't have an open-source repo since I use it in an internal proprietary tool.
Here is how it looks after the update:
Here is how it looks when I revert changes:
Google Chrome 120, Windows 11.
811a062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll try to repro asap. Very weird behavior. I’ll keep you posted
811a062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the issue, will open a PR.
811a062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test if the css from PR #705 solves your problem, and leave a comment on the PR? :)