-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svelte-sonner slots #1062
Comments
also i would be glad to work on this, and if needed update the docs |
That would be great @Carlos-err406 ! |
@huntabyte Do you think it's sane to copy and paste the Icon and Loader components from svelte-sonner, to use as default values of the slots, or is it better to get a quick PR on svelte-sonner to export the Icon component (and Loader) to the index? i dont know their stand on that though or maybe is preferable to just use lucide-svelte icons and forget about the defaults of svelte-sonner? |
tried the lucide icons approach, i think it came out pretty nice |
EDIT: Apologies, Svelte 5 did not give a warning/error for my example and because it doesn't work, it used a cached version and I commented a bit prematurely, before I realised. For posterity, this is what I tried adding to
I started trying to write a wrapper but I still couldn't easily get it to work as desired, even with Svelte 5's snippets, so I think it's easiest to use the changes in the PR if anyone needs the functionality. |
With snippets coming up in |
Describe the feature
the original svelte-sonner provides slots for modifying the default iconst of the toast
see this section of the svelte-sonner readme
my request is to add those slots to the installed component to make it more extendable, and so users dont have to modify the /ui/sonner.svelte component just to add them
The text was updated successfully, but these errors were encountered: