-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sonner slots for modifying icons #1066
base: main
Are you sure you want to change the base?
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
1bc4e69
to
8a77b9a
Compare
bc5adbb
to
3fa6901
Compare
3fa6901
to
7a168e1
Compare
895639c
to
aa6761d
Compare
Hey there! Thanks for taking the time to add this. I'm cool with exposing the slots, but not sure how I feel about setting those default icons as the fallbacks. I will experiment a bit with it to see how it feels! |
of course! thank you! edit: i tried using the ones that looked most to the original ones, to my perception |
@huntabyte maybe if this gets merged on svelte-sonner we dont have to use lucide-icons as fallbacks. |
aa6761d
to
85fb4ca
Compare
85fb4ca
to
647657d
Compare
647657d
to
cc46e8e
Compare
now using same fallbacks as svelte-sonner since now Icon and Loader are exported |
addresses #1062
locked
one does not have the slots feature