Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sonner slots for modifying icons #1066

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Carlos-err406
Copy link
Contributor

@Carlos-err406 Carlos-err406 commented May 3, 2024

addresses #1062

  • updated svelte-sonner version since the locked one does not have the slots feature

Copy link

changeset-bot bot commented May 3, 2024

⚠️ No Changeset found

Latest commit: 5390464

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 3, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 5390464

@huntabyte
Copy link
Owner

Hey there! Thanks for taking the time to add this.

I'm cool with exposing the slots, but not sure how I feel about setting those default icons as the fallbacks.

I will experiment a bit with it to see how it feels!

@Carlos-err406
Copy link
Contributor Author

Carlos-err406 commented May 5, 2024

of course! thank you!

edit: i tried using the ones that looked most to the original ones, to my perception

@Carlos-err406
Copy link
Contributor Author

@huntabyte maybe if this gets merged on svelte-sonner we dont have to use lucide-icons as fallbacks.

wobsoriano/svelte-sonner#96

@Carlos-err406
Copy link
Contributor Author

now using same fallbacks as svelte-sonner since now Icon and Loader are exported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants