Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Self closing tags issue #1026

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: Self closing tags issue #1026

merged 2 commits into from
Apr 18, 2024

Conversation

TheOnlyTails
Copy link
Contributor

Fixes the issue raised by Rich Harris here: sveltejs/svelte#11052, wherein it is pointed out how self closing tags in HTML are a lie, and <div /> is equivalent to an unclosed <div>.
I simply ran the self closing tags migration provided by svelte-migrate on the project.

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: 850ff29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 17, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 850ff29

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@huntabyte huntabyte merged commit 1f320b4 into huntabyte:main Apr 18, 2024
4 checks passed
@TheOnlyTails TheOnlyTails deleted the patch-1 branch April 18, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants