Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to add a button to close a dialog #1038

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

Thecrafterja
Copy link
Contributor

This PR exposes the DialogPrimitive.Close as DialogClose to give the ability to use a button to close a dialog.

Code according to the solution discussed in this discussion #1030
Solution to issue #1029

Copy link

changeset-bot bot commented Apr 20, 2024

⚠️ No Changeset found

Latest commit: dd0744e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 20, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview dd0744e

@Thecrafterja
Copy link
Contributor Author

Idea: Maybe the "Save Changes" button on the component page (https://www.shadcn-svelte.com/docs/components/dialog) should be inserted into a DialogClose element

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit c5dc4d1 into huntabyte:main Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants