Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initialize scrollSnapsStore on init #1055

Merged
merged 2 commits into from
Apr 29, 2024
Merged

feat: initialize scrollSnapsStore on init #1055

merged 2 commits into from
Apr 29, 2024

Conversation

shyakadavis
Copy link
Contributor

Follow-up for #1052

I'm really sorry for forgetting this; glad I was reminded of it when doing some Embal-related research here: davidjerleke/embla-carousel#847 (reply in thread)

Speaking of, wanted to send a P.R for initializing the view slides as well, but that sounds too specific (like my use case), thus forewent that.

Thanks.

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Apr 29, 2024

⚠️ No Changeset found

Latest commit: 6b6b88c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 29, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 6b6b88c

@huntabyte
Copy link
Owner

huntabyte commented Apr 29, 2024

Is this already taken care of in the default style as well?

Edit: I just checked, and I'm not seeing it. Let's make sure it's added there as well so the two styles have feature parity.

Thank you!

@shyakadavis
Copy link
Contributor Author

Oops. My bad, Hunter.

@shyakadavis
Copy link
Contributor Author

Done, @huntabyte

Thanks. 🙂

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte changed the title chore: initialize scrollSnapsStore on init feat: initialize scrollSnapsStore on init Apr 29, 2024
@huntabyte huntabyte merged commit 224110e into huntabyte:main Apr 29, 2024
4 checks passed
@shyakadavis shyakadavis deleted the chore/initialize-snapstore branch April 30, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants