-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialize scrollSnapsStore
on init
#1055
feat: initialize scrollSnapsStore
on init
#1055
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Is this already taken care of in the Edit: I just checked, and I'm not seeing it. Let's make sure it's added there as well so the two styles have feature parity. Thank you! |
Oops. My bad, Hunter. |
Done, @huntabyte Thanks. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
scrollSnapsStore
on initscrollSnapsStore
on init
Follow-up for #1052
I'm really sorry for forgetting this; glad I was reminded of it when doing some Embal-related research here: davidjerleke/embla-carousel#847 (reply in thread)
Speaking of, wanted to send a P.R for initializing the view slides as well, but that sounds too specific (like my use case), thus forewent that.
Thanks.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.pnpm format
andpnpm lint