Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace node-fetch for a smaller package #1144

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

AdrianGonz97
Copy link
Collaborator

node-fetch is humongous, sitting at a hefty 17MB (this includes the size of it's modules and dependencies). The total package size of shadcn-svelte is 18MB. node-fetch makes up the vast majority of it.

This PR replaces it with node-fetch-native, which is ~700KB, drastically reducing our package size.

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Jun 16, 2024

🦋 Changeset detected

Latest commit: 5a497b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
shadcn-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AdrianGonz97 AdrianGonz97 merged commit f201baa into main Jun 16, 2024
3 checks passed
@huntabyte huntabyte deleted the chore/replace-node-fetch branch October 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant