Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update svelte-add install command #1217

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

AdrianGonz97
Copy link
Collaborator

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 52fd96c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 26, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 52fd96c

@AdrianGonz97 AdrianGonz97 merged commit 2e295be into main Jul 26, 2024
4 checks passed
@@ -16,7 +16,7 @@ description: How to setup shadcn-svelte manually.
Use the `svelte-add` CLI to add Tailwind CSS to your project.

```bash
npx @svelte-add/tailwindcss@latest
npx svelte-add@latest tailwindcss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using it without @latest and it's been working just fine since we started pinning the dependency versions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I think it's probably fine with npm and pnpm, but I still worry about the aggressive caching strategy of the other package managers, like bun who's biggest offender of this

even trying it now, it's giving me 2.3.3 of svelte-add 🙃
img

@huntabyte huntabyte deleted the docs/update-svelte-add branch October 20, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants