Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli changes #1235

Closed
wants to merge 3 commits into from
Closed

Conversation

fernandolguevara
Copy link
Contributor

@fernandolguevara fernandolguevara commented Aug 13, 2024

  • getPackageManager try with user defined agent first
  • log which package manager is executing dependencies installation imagen
  • process only missing deps on Installing package dependencies step

Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: 49c6be2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 13, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 49c6be2

@AdrianGonz97
Copy link
Collaborator

Thank you, but I think this is doing a bit too much. I do like the idea of specifying which package manager is being used, but besides that, I'm not a fan of the other changes.

It may be easier to start a new PR (especially since we just changed how package managers are detected), so please feel free to open a new one with just the package manager change. thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants