Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: install dependencies as dev deps #1315

Merged
merged 4 commits into from
Oct 12, 2024
Merged

cli: install dependencies as dev deps #1315

merged 4 commits into from
Oct 12, 2024

Conversation

huntabyte
Copy link
Owner

@huntabyte huntabyte commented Oct 11, 2024

Closes #1304

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: d0a6354

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
shadcn-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 11, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview d0a6354

@ieedan
Copy link
Contributor

ieedan commented Oct 11, 2024

I didn't see you were working on this.

I have pretty much the same thing but I upgraded package-manager-detector to 0.2.2 so we could use the resolveCommand api.

@huntabyte
Copy link
Owner Author

I didn't see you were working on this.

I have pretty much the same thing but I upgraded package-manager-detector to 0.2.2 so we could use the resolveCommand api.

Thank you! We can refactor to use resolveCommand in the @next branch.

@huntabyte huntabyte merged commit bc787f3 into main Oct 12, 2024
4 checks passed
@huntabyte huntabyte deleted the cli/dev-deps branch October 12, 2024 13:41
@ieedan
Copy link
Contributor

ieedan commented Oct 12, 2024

I didn't see you were working on this.
I have pretty much the same thing but I upgraded package-manager-detector to 0.2.2 so we could use the resolveCommand api.

Thank you! We can refactor to use resolveCommand in the @next branch.

Opened #1319 on @next

@filiabel
Copy link

Should this apply to svelte-headless-table as well?

https://www.shadcn-svelte.com/docs/components/data-table#installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies like bits-ui should be installed as devDependencies and not dependencies
4 participants