Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: pin deps #1553

Merged
merged 6 commits into from
Dec 13, 2024
Merged

registry: pin deps #1553

merged 6 commits into from
Dec 13, 2024

Conversation

huntabyte
Copy link
Owner

As we release new majors for dependencies that only support Svelte 5, we'll pin those dependencies to their latest Svelte 4-supported version.

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: a074602

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ieedan
Copy link
Contributor

ieedan commented Dec 13, 2024

Just a thought but a better way to do this may be to just use the version found in the nearest package.json. This way you don't have to maintain a list.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview a074602

@huntabyte
Copy link
Owner Author

huntabyte commented Dec 13, 2024

Just a thought but a better way to do this may be to just use the version found in the nearest package.json. This way you don't have to maintain a list.

We considered that before but then it would make more sense to do it for all the deps, which means anytime a patch release for anything comes out, we also need to update shadcn-svelte or users may have issues.

There will only be a few of these, and the previous versions of the packages will not be updated once the new major is out, so I don't mind the list.

@huntabyte huntabyte merged commit 9abaa83 into main Dec 13, 2024
4 checks passed
@huntabyte huntabyte deleted the registry/pin-deps branch December 13, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants