Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Using a Proxy to Fetch from shadcn Registry #402

Merged
merged 8 commits into from
Nov 5, 2023

Conversation

shahradelahi
Copy link
Contributor

Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: bfe94a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
shadcn-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
shadcn-svelte ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 3:10pm

@huntabyte
Copy link
Owner

Hey there @shahradelahi this is great! Do you think it's worth adding that this support exists to the CLI documentation?

@shahradelahi
Copy link
Contributor Author

Hi there,

I'm not entirely certain, but I added a --proxy flag to the add command. However, it might be helpful to log a warning message, so that the user knows whether they are using a proxy or not.

Please let me know if you think any further changes are needed.

@huntabyte
Copy link
Owner

Thanks for this! I more so meant within the https://shadcn-svelte.com/docs/cli page which gives instructions on how to use with a proxy!

@huntabyte
Copy link
Owner

Is this good to go? @shahradelahi

@shahradelahi
Copy link
Contributor Author

@huntabyte, In the preview deployment, the document section that I added is not being displayed. Other than that, everything looks good to go. Thank you for the review. 🌷

@huntabyte huntabyte merged commit 614681f into huntabyte:main Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants