Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped Select and Chevron in a div for NativeSelect component #444

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Wrapped Select and Chevron in a div for NativeSelect component #444

merged 2 commits into from
Nov 14, 2023

Conversation

babakfp
Copy link
Contributor

@babakfp babakfp commented Nov 13, 2023

Fixes #305

Copy link

changeset-bot bot commented Nov 13, 2023

⚠️ No Changeset found

Latest commit: 128619c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 4:14pm

@babakfp
Copy link
Contributor Author

babakfp commented Nov 13, 2023

Should I remove this relative class here?

image

image

https://www.shadcn-svelte.com/examples/forms/appearance

src\routes\examples\forms\appearance\appearance-form.svelte

I think this was added to solve the same issue discussed in #305.

@huntabyte
Copy link
Owner

Yeah if we're already adding a relative container into it we shouldn't need it. When you try removing it as long as everything still looks good for that example form I'm cool with dropping it.

@babakfp
Copy link
Contributor Author

babakfp commented Nov 14, 2023

Yeah if we're already adding a relative container into it we shouldn't need it. When you try removing it as long as everything still looks good for that example form I'm cool with dropping it.

All good. Added the Removed class commit.

@huntabyte huntabyte merged commit 701ad97 into huntabyte:main Nov 14, 2023
3 checks passed
@babakfp babakfp deleted the 305 branch November 14, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Form.NativeSelect> doesn't properly render arrow svg
2 participants