Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drawer, Sonner, & Pagination #585

Merged
merged 18 commits into from
Jan 2, 2024
Merged

feat: Drawer, Sonner, & Pagination #585

merged 18 commits into from
Jan 2, 2024

Conversation

huntabyte
Copy link
Owner

@huntabyte huntabyte commented Jan 2, 2024

This PR adds the Drawer, Sonner, and Pagination components to shadcn-svelte.

Closes: #552 #567

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Follows the contribution guidelines.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Jan 2, 2024

⚠️ No Changeset found

Latest commit: 3e863c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 3:16am

@huntabyte huntabyte merged commit db84fdb into main Jan 2, 2024
4 checks passed
@huntabyte huntabyte deleted the feat/sonner-toast branch January 2, 2024 03:19
@shimkiv
Copy link
Contributor

shimkiv commented Jan 2, 2024

Hey @huntabyte, thank you for this update.
One thing though. On the web-site (changelog and sonner sections) you mention that https://sonner-svelte.vercel.app/ is in use for Sonner component, when in fact Shadcn-Svelte CLI installs this one https://github.com/wobsoriano/svelte-sonner

@shimkiv
Copy link
Contributor

shimkiv commented Jan 2, 2024

Updated by #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Command.Input positioning in Dashboard example
3 participants