-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update icon imports/radix-icons-svelte
-> svelte-radix
#591
feat: update icon imports/radix-icons-svelte
-> svelte-radix
#591
Conversation
🦋 Changeset detectedLatest commit: 71a9b68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
So far so good! Turns out that I didn't have to adjust the registry script at all as we handle the dependencies for icons a little differently. In regards to the current As soon as that's merged and released, we can merge this PR. Edit: |
Glad to hear. Best of luck, stranger. 🙂 |
https://github.com/ciscoheat/sveltekit-superforms/releases/tag/v1.13.2 Superforms has exposed the type for this now. |
Alrighty, I've merged in Since there doesn't seem to be a Radix Icons for Svelte with proper exports setup I'll look into spinning something up this week. |
Swapped Default style- import { Check } from 'lucide-svelte'
+ import Check from 'lucide-svelte/icons/check' New York style- import { Check } from 'radix-icons-svelte'
+ import Check from 'svelte-radix/Check.svelte' |
radix-icons-svelte
w/ svelte-radix
Thanks a ton peeps! @shyakadavis @AdrianGonz97 |
radix-icons-svelte
w/ svelte-radix
radix-icons-svelte
-> svelte-radix
Before submitting the PR, please make sure you do the following
Fixes: #575
For faster load times & builds, icons will now be imported as such:
P.S.
With the
"moduleResolution: "Bundler"
option, the TS compiler was screaming its lungs out due tosvelte-headless-table
. I updated it given the new release https://github.com/bryanmylee/svelte-headless-table/releases/tag/v0.18.0, and updated some type imports, and all is well now.feat:
,fix:
,chore:
, ordocs:
.pnpm format
andpnpm lint