Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add mode-watcher to Sonner registry deps #602

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

huntabyte
Copy link
Owner

@huntabyte huntabyte commented Jan 4, 2024

The Sonner component needs us to specify a theme, otherwise it will default to the system preference. If the <ModeWatcher /> component is not being used, it will also default to "system". If you decide you do not want to use mode-watcher, you can simply remove it from your component and replace it with whatever you'd like.

This is aligned with how the original shadcn/ui's installation works, where next-themes is installed to keep the toast theme in sync with your app's theme.

Fixes: #595

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Follows the contribution guidelines.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: f6ad398

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
www Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 3:25pm

@huntabyte huntabyte merged commit 1ba3100 into main Jan 4, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/sonner-deps branch January 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mode-watcher in sonner component
1 participant