Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): installation instruction for plain svelte vite #631

Merged

Conversation

doaortu
Copy link
Contributor

@doaortu doaortu commented Jan 10, 2024

Why?

The installation instruction for plain svelte + vite (i.e. not sveltekit) is missing step to also edit the resolve config in vite.config.js, so that vite can understand the $lib alias.

Note:

I've read the contributing guide, and I think I don't need to open an issue because this PR is trivial enough.

Before submitting the PR, please make sure you do the following

  • This message body should clearly illustrate what problems it solves.
  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Follows the contribution guidelines.
  • Format & lint the code with pnpm format and pnpm lint
  • Prefix your PR title with feat:, fix:, chore:, or docs:.

beside editing tsconfig.json, we need also update the resolve option of vite.config.js
Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: f321a17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 6:39pm

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AdrianGonz97
Copy link
Collaborator

thank you!

@AdrianGonz97 AdrianGonz97 merged commit e6e3eba into huntabyte:main Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants