Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Form.SelectTrigger more flexible #634

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

huntabyte
Copy link
Owner

@huntabyte huntabyte commented Jan 12, 2024

Closes: #601

This PR makes the Form.Value the slot fallback within the Form.SelectTrigger, meaning if children are passed to it, the Form.Value will no longer render. You can access the value of the field via the value slot prop.

This means if you choose to use the child slot of the SelectTrigger, you'll need to manually handle displaying the placeholder if the value isn't present. In this example, the field contains a string value, so the default would be an empty string.

 <Form.SelectTrigger let:value>
	{value !== "" ? value : "Placeholder here"}
</Form.SelectTrigger>

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Follows the contribution guidelines.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Jan 12, 2024

⚠️ No Changeset found

Latest commit: 9673430

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview Jan 12, 2024 1:08am

@huntabyte huntabyte merged commit d48d69f into main Jan 12, 2024
5 checks passed
@huntabyte huntabyte deleted the form-select-trigger-slot branch January 12, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant