feat: make Form.SelectTrigger
more flexible
#634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #601
This PR makes the
Form.Value
the slot fallback within theForm.SelectTrigger
, meaning if children are passed to it, theForm.Value
will no longer render. You can access thevalue
of the field via thevalue
slot prop.This means if you choose to use the child slot of the
SelectTrigger
, you'll need to manually handle displaying the placeholder if the value isn't present. In this example, the field contains a string value, so the default would be an empty string.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.pnpm format
andpnpm lint