Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carousel prev/next behavior #662

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix: carousel prev/next behavior #662

merged 2 commits into from
Jan 18, 2024

Conversation

huntabyte
Copy link
Owner

@huntabyte huntabyte commented Jan 18, 2024

Closes: #659

This PR refactors some of the internals of the carousel to fix a bug related to drag events being triggered when the previous/next buttons were pressed. It is advised to update/completely re-add these components. We moved where the action is applied as well as added some stores to the context to keep the same APIs.

Before submitting the PR, please make sure you do the following

  • If your PR isn't addressing a small fix (like a typo), it references an issue where it is discussed ahead of time and assigned to you. In many cases, features are absent for a reason.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Follows the contribution guidelines.
  • Format & lint the code with pnpm format and pnpm lint

Copy link

changeset-bot bot commented Jan 18, 2024

⚠️ No Changeset found

Latest commit: c9fc72f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 2:06am

@huntabyte huntabyte merged commit 77ec6a8 into main Jan 18, 2024
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/659 branch January 18, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel momentum doesn't work when tapping the carousel previous/next buttons multiple times
1 participant