-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add package manager dropdown on copy button #675
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dope! Thanks a ton, just a minor thing! Let me know if you want me to take care of it (I try not to intrude on PRs without permission!)
Also, the comments are much appreciated! Probably should have been there from the beginning! The plugins are quite the work of art right? 😂 Took me a bit to figure out how to get this site to behave like the original!
Haha yeah you can modify it no problem!!
OMG yeah, fortunately I had some basis, and my recent work on svelte-changelog got me in better shape to work on that! When I got assigned this feature and that I later noticed it was not as simple (I thought) as a few more lines of Svelte I was like man, I should've really planned my feature before having to dig into that for the first time! I wasn't even sure I could bring the feature I requested into life and I'd be looking like a jerk haha. |
CleanShot.2024-01-21.at.11.07.24.mp4The dropdown doesn't appear to work on this one command 🤔 |
Indeed! It isn't in the conditions we discussed, because it wasn't needed for React. Adding that case right now, sorry. FYIReading again the docs I linked above, EditHere are the changes I made:
|
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.pnpm format
andpnpm lint
Fixes #642.
I finally got time to lean into this feature. What took time was getting more familiar with mdsvex and rehype/remark plugins, which I never really did before (only using
md
➜html
, never contributed to them, or even wondered how they were working).At the end of the day, instead of blindly copying what shadcn did for the original website, I preferred a Sveltier approach: simpler, type-safe and shorter.
Hope you like it!