Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing examples / themes #699

Closed
wants to merge 6 commits into from
Closed

docs: Fixing examples / themes #699

wants to merge 6 commits into from

Conversation

Scooter1337
Copy link
Contributor

@Scooter1337 Scooter1337 commented Jan 24, 2024

Closes: #701

Fixing /examples

  • Found that Model selection had a small error. (see first commit, and fourth commit for edit)

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 2:00am

Copy link

changeset-bot bot commented Jan 24, 2024

⚠️ No Changeset found

Latest commit: 0294a8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Scooter1337
Copy link
Contributor Author

Scooter1337 commented Jan 24, 2024

  • Second commit fixes small spell error
  • Third/fifth commit close Theme docs duplicated cards are broken #701
  • Third commit also fixes the team-member popovers. They couldn't be opened as the triggers were missing their builder.

Copy link
Contributor Author

@Scooter1337 Scooter1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implements Huntabyte's recommendation

@Scooter1337 Scooter1337 changed the title docs: Fixing playground example docs: Fixing examples / themes Jan 25, 2024
@Scooter1337
Copy link
Contributor Author

Now closes #701

@Scooter1337
Copy link
Contributor Author

Sadly don't really understand what's going on with the hover card issue (#697).

But this pull request still cleans up the examples!

@Scooter1337 Scooter1337 marked this pull request as ready for review January 25, 2024 02:07
@huntabyte huntabyte mentioned this pull request Jan 25, 2024
5 tasks
@huntabyte
Copy link
Owner

Closing in favor of #703 which includes your commits/contributions. In the future, please submit PRs from a branch other than your main branch of the fork, as main doesn't allow me to make modifications locally and push them to the PR without jumping through hoops.

@huntabyte huntabyte closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme docs duplicated cards are broken
2 participants